Add checks to prevent formatting hxxps #405
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) sanitizeUrl.ts: if the url starts with hxxps it will return the url 2) transformLinks.ts: checks to make sure the url does not start with hxxps 3) url.ts: if the input starts with hxxps it will return it I tried my best to dig through these files to solve this (https://protonmail.uservoice.com/forums/284483-proton-mail/suggestions/48747251-stop-hyperlinking-hxxps) instead of just complaining about it.
kboshold
suggested changes
Sep 19, 2024
| @@ -51,7 +51,7 @@ const sanitizeRelativeHttpLinks = (link: HTMLLinkElement) => { | |||
| // link.href is the absolute value of the link: mail.proton.me is prepended, use getAttribute | |||
| const url = link.getAttribute('href'); | |||
|
|
|||
| if (url) { | |||
| if (url && !url.toLowerCase().startsWith('hxxps')) { | |||
There was a problem hiding this comment.
Does the customization in this function make any sense at all? A URL is always passed without a protocol and if this starts with hxxps, then in my opinion the http:// should still be added.
Example hxxps.example.com should become http://hxxps.example.com. With your adjustment it will not longer work.
| @@ -3,6 +3,10 @@ export const sanitizeUrl = (url: string): string | undefined => { | |||
| return undefined | |||
| } | |||
|
|
|||
| if (url.toLowerCase().startsWith('hxxps')) { | |||
There was a problem hiding this comment.
The check should probably be moved to line 16 and you should use the parsedUrl.protocol for the check. Also check hxxps and hxxp.
| @@ -229,6 +229,9 @@ export const getApiSubdomainUrl = (pathname: string, origin: string) => { | |||
| }; | |||
|
|
|||
| export const getAppUrlFromApiUrl = (apiUrl: string, appName: APP_NAMES) => { | |||
| if (apiUrl.toLowerCase().startsWith('hxxps')) { | |||
There was a problem hiding this comment.
Does this test really make sense in this context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried my best to dig through these files to solve this (https://protonmail.uservoice.com/forums/284483-proton-mail/suggestions/48747251-stop-hyperlinking-hxxps) instead of just complaining about it. Feel free to refactor, reformat, or edit. Thanks for the consideration.